[
https://issues.apache.org/jira/browse/CASSANDRA-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471412#comment-16471412
]
mck commented on CASSANDRA-12924:
---------------------------------
{quote}presumably contains no breaking API changes{quote}
Good call. I've ran-through the [change list|http://example.com] and [code
diffs|https://github.com/dropwizard/metrics/compare/v3.1.0...v3.1.5] from 3.1.0
to 3.1.5, checking for anything that must cause trouble.
Nothing stands out.
Public signature changes are:
- {{Slf4jReporter.Builder.prefixedWith(..)}} added, and
- {{Slf4jReporter.LoggerProxy.isEnabled()}} added.
Noticeable behaviour changes:
- TCP connections are no longer re-used when sending the metrics,
- DNS retries can now happen, and
- {{metrics-jvm}}'s {{MemoryUsageGaugeSet}} has new metrics: max, used,
committed, init; for each memory pool.
> GraphiteReporter does not reconnect if graphite restarts
> --------------------------------------------------------
>
> Key: CASSANDRA-12924
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12924
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stefano Ortolani
> Assignee: mck
> Priority: Major
> Fix For: 3.11.3
>
>
> Seems like GraphiteReporter does not reconnect after graphite is restarted.
> The consequence is complete loss of reported metrics until Cassandra
> restarts. Logs show this every minute:
> {noformat}
> WARN [metrics-graphite-reporter-1-thread-1] 2016-11-17 10:06:26,549
> GraphiteReporter.java:179 - Unable to report to Graphite
> java.net.SocketException: Broken pipe
> at java.net.SocketOutputStream.socketWrite0(Native Method)
> ~[na:1.8.0_91]
> at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:109)
> ~[na:1.8.0_91]
> at java.net.SocketOutputStream.write(SocketOutputStream.java:153)
> ~[na:1.8.0_91]
> at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221)
> ~[na:1.8.0_91]
> at sun.nio.cs.StreamEncoder.implWrite(StreamEncoder.java:282)
> ~[na:1.8.0_91]
> at sun.nio.cs.StreamEncoder.write(StreamEncoder.java:125) ~[na:1.8.0_91]
> at java.io.OutputStreamWriter.write(OutputStreamWriter.java:207)
> ~[na:1.8.0_91]
> at java.io.BufferedWriter.flushBuffer(BufferedWriter.java:129)
> ~[na:1.8.0_91]
> at java.io.BufferedWriter.write(BufferedWriter.java:230) ~[na:1.8.0_91]
> at java.io.Writer.write(Writer.java:157) ~[na:1.8.0_91]
> at com.codahale.metrics.graphite.Graphite.send(Graphite.java:130)
> ~[metrics-graphite-3.1.0.jar:3.1.0]
> at
> com.codahale.metrics.graphite.GraphiteReporter.reportGauge(GraphiteReporter.java:283)
> ~[metrics-graphite-3.1.0.jar:3.1.0]
> at
> com.codahale.metrics.graphite.GraphiteReporter.report(GraphiteReporter.java:158)
> ~[metrics-graphite-3.1.0.jar:3.1.0]
> at
> com.codahale.metrics.ScheduledReporter.report(ScheduledReporter.java:162)
> [metrics-core-3.1.0.jar:3.1.0]
> at
> com.codahale.metrics.ScheduledReporter$1.run(ScheduledReporter.java:117)
> [metrics-core-3.1.0.jar:3.1.0]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [na:1.8.0_91]
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> [na:1.8.0_91]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> [na:1.8.0_91]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> [na:1.8.0_91]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_91]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_91]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_91]
> WARN [metrics-graphite-reporter-1-thread-1] 2016-11-17 10:06:26,549
> GraphiteReporter.java:183 - Error closing Graphite
> java.net.SocketException: Broken pipe
> at java.net.SocketOutputStream.socketWrite0(Native Method)
> ~[na:1.8.0_91]
> at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:109)
> ~[na:1.8.0_91]
> at java.net.SocketOutputStream.write(SocketOutputStream.java:153)
> ~[na:1.8.0_91]
> at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221)
> ~[na:1.8.0_91]
> at sun.nio.cs.StreamEncoder.implWrite(StreamEncoder.java:282)
> ~[na:1.8.0_91]
> at sun.nio.cs.StreamEncoder.write(StreamEncoder.java:125) ~[na:1.8.0_91]
> at java.io.OutputStreamWriter.write(OutputStreamWriter.java:207)
> ~[na:1.8.0_91]
> at java.io.BufferedWriter.flushBuffer(BufferedWriter.java:129)
> ~[na:1.8.0_91]
> at java.io.BufferedWriter.write(BufferedWriter.java:230) ~[na:1.8.0_91]
> at java.io.Writer.write(Writer.java:157) ~[na:1.8.0_91]
> at com.codahale.metrics.graphite.Graphite.send(Graphite.java:130)
> ~[metrics-graphite-3.1.0.jar:3.1.0]
> at
> com.codahale.metrics.graphite.GraphiteReporter.reportGauge(GraphiteReporter.java:283)
> ~[metrics-graphite-3.1.0.jar:3.1.0]
> at
> com.codahale.metrics.graphite.GraphiteReporter.report(GraphiteReporter.java:158)
> ~[metrics-graphite-3.1.0.jar:3.1.0]
> at
> com.codahale.metrics.ScheduledReporter.report(ScheduledReporter.java:162)
> [metrics-core-3.1.0.jar:3.1.0]
> at
> com.codahale.metrics.ScheduledReporter$1.run(ScheduledReporter.java:117)
> [metrics-core-3.1.0.jar:3.1.0]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [na:1.8.0_91]
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> [na:1.8.0_91]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> [na:1.8.0_91]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> [na:1.8.0_91]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_91]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_91]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_91]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
