[
https://issues.apache.org/jira/browse/CASSANDRA-14444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472373#comment-16472373
]
ASF GitHub Bot commented on CASSANDRA-14444:
--------------------------------------------
GitHub user xiaodong-xie opened a pull request:
https://github.com/apache/cassandra/pull/225
Fix NPE, CASSANDRA-14444
The detail was mentioned in:
https://issues.apache.org/jira/browse/CASSANDRA-14444
Thanks a lot.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiaodong-xie/cassandra fix-NPE
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cassandra/pull/225.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #225
----
commit eb36aadad44c8374f7c2dabe0bc989976d9025a8
Author: Xiaodong Xie <xiaodongxie329@...>
Date: 2018-05-11T17:57:16Z
Fix NPE, CASSANDRA-14444
----
> Got NPE when querying Cassandra 3.11.2
> --------------------------------------
>
> Key: CASSANDRA-14444
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14444
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
> Environment: Ubuntu 14.04, JDK 1.8.0_171.
> Cassandra 3.11.2
> Reporter: Xiaodong Xie
> Priority: Major
>
> We just upgraded our Cassandra cluster from 2.2.6 to 3.11.2
> After upgrading, we immediately got exceptions in Cassandra like this one:
>
> ERROR [Native-Transport-Requests-1] 2018-05-11 17:10:21,994
> QueryMessage.java:129 - Unexpected error during query
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.dht.RandomPartitioner.getToken(RandomPartitioner.java:248)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at
> org.apache.cassandra.dht.RandomPartitioner.decorateKey(RandomPartitioner.java:92)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at org.apache.cassandra.config.CFMetaData.decorateKey(CFMetaData.java:666)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at
> org.apache.cassandra.service.pager.PartitionRangeQueryPager.<init>(PartitionRangeQueryPager.java:44)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at
> org.apache.cassandra.db.PartitionRangeReadCommand.getPager(PartitionRangeReadCommand.java:268)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at
> org.apache.cassandra.cql3.statements.SelectStatement.getPager(SelectStatement.java:475)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:288)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:118)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at
> org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:224)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:255)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:240)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at
> org.apache.cassandra.transport.messages.QueryMessage.execute(QueryMessage.java:116)
> ~[apache-cassandra-3.11.2.jar:3.11.2]
> at
> org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:517)
> [apache-cassandra-3.11.2.jar:3.11.2]
> at
> org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:410)
> [apache-cassandra-3.11.2.jar:3.11.2]
> at
> io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
> [netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:357)
> [netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.access$600(AbstractChannelHandlerContext.java:35)
> [netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext$7.run(AbstractChannelHandlerContext.java:348)
> [netty-all-4.0.44.Final.jar:4.0.44.Final]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [na:1.8.0_171]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162)
> [apache-cassandra-3.11.2.jar:3.11.2]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [apache-cassandra-3.11.2.jar:3.11.2]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_171]
>
> The table schema is like:
> CREATE TABLE example.example_table (
> id bigint,
> hash text,
> json text,
> PRIMARY KEY (id, hash)
> ) WITH COMPACT STORAGE
>
> The query is something like:
> "select * from example.example_table;" // (We do know this is bad practise,
> and we are trying to fix that right now)
> with fetch-size as 200, using DataStax Java driver.
> This table contains about 20k rows.
>
> Actually, the fix is quite simple,
>
> --- a/src/java/org/apache/cassandra/service/pager/PagingState.java
> +++ b/src/java/org/apache/cassandra/service/pager/PagingState.java
> @@ -46,7 +46,7 @@ public class PagingState
> public PagingState(ByteBuffer partitionKey, RowMark rowMark, int remaining,
> int remainingInPartition)
> {
> - this.partitionKey = partitionKey;
> + this.partitionKey = partitionKey == null ? ByteBufferUtil.EMPTY_BYTE_BUFFER
> : partitionKey;
> this.rowMark = rowMark;
> this.remaining = remaining;
> this.remainingInPartition = remainingInPartition;
>
> "partitionKey == null ? ByteBufferUtil.EMPTY_BYTE_BUFFER : partitionKey;" is
> in 2.2.6 and 2.2.8. But it was removed for some reason.
> The interesting part is that, we have:
> public final ByteBuffer partitionKey; // Can be null for single partition
> queries.
> It seems "partitionKey" could be null.
> Thanks a lot.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
