[
https://issues.apache.org/jira/browse/CASSANDRA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473335#comment-16473335
]
mck commented on CASSANDRA-13121:
---------------------------------
[~ptbannister], i've put in your patches for testing (including your dtest
change).
I'll take a closer look at the code and can commit if all looks ok.
|| Branch || uTest || aTest || dTest ||
|
[cassandra-3.0_13121|https://github.com/thelastpickle/cassandra/tree/mck/cassandra-3.0_13121]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.0_13121.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.0_13121]
|
[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/29/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/29]
|
[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/556/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/556]
|
|
[cassandra-3.11_13121|https://github.com/thelastpickle/cassandra/tree/mck/cassandra-3.11_13121]
|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.11_13121.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.11_13121
]|
[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/30/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/30]
|
[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/557/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/557]
|
|
[dtest_13121|https://github.com/thelastpickle/cassandra-dtest/tree/mck/CASSANDRA-13121]
|[!https://circleci.com/gh/thelastpickle/workflows/cassandra-dtest/tree/mck%2FCASSANDRA-13121.svg?style=svg!|https://circleci.com/gh/thelastpickle/workflows/cassandra-dtest/tree/mck%2FCASSANDRA-13121]|
| |
> repair progress message breaks legacy JMX support
> -------------------------------------------------
>
> Key: CASSANDRA-13121
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13121
> Project: Cassandra
> Issue Type: Bug
> Components: Streaming and Messaging
> Reporter: Scott Bale
> Assignee: Patrick Bannister
> Priority: Minor
> Labels: jmx, lhf, notifications, repair
> Fix For: 3.0.x, 3.11.x
>
> Attachments: 13121-3.0.txt
>
>
> The error progress message in {{RepairRunnable}} is not compliant with the
> {{LegacyJMXProgressSupport}} class, which uses a regex to match on the text
> of a progress event. Therefore, actual failures slip through as successes if
> using legacy JMX for repairs.
> In {{RepairRunnable}}
> {code}
> protected void fireErrorAndComplete(String tag, int progressCount, int
> totalProgress, String message)
> {
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.ERROR,
> progressCount, totalProgress, message));
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.COMPLETE,
> progressCount, totalProgress, String.format("Repair command #%d finished with
> error", cmd)));
> }
> {code}
> Note the {{"Repair command #%d finished with error"}}
> See
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L109
> In {{LegacyJMXProgressSupport}}:
> {code}
> protected static final Pattern SESSION_FAILED_MATCHER =
> Pattern.compile("Repair session .* for range .* failed with error .*");
> protected static final Pattern SESSION_SUCCESS_MATCHER =
> Pattern.compile("Repair session .* for range .* finished");
> {code}
> See
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/progress/jmx/LegacyJMXProgressSupport.java#L38
> Legacy JMX support was introduced for CASSANDRA-11430 (version 2.2.6) and the
> bug was introduced as part of CASSANDRA-12279 (version 2.2.8).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
