[ https://issues.apache.org/jira/browse/CASSANDRA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477263#comment-16477263 ]
Jordan West commented on CASSANDRA-14417: ----------------------------------------- Looks like the most recent changes moved the second {{if (shouldCountKeys)}} into the upper while loop, which I don't think was intended. branch: [https://github.com/krummas/cassandra/blob/f207720a45c9106cfbdd4e8ab8f34283c58cba52/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L741-L756] vs. Trunk: [https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L741-L757] > nodetool import cleanup/fixes > ----------------------------- > > Key: CASSANDRA-14417 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14417 > Project: Cassandra > Issue Type: Improvement > Reporter: Marcus Eriksson > Assignee: Marcus Eriksson > Priority: Major > Fix For: 4.x > > > * We shouldn't expose importNewSSTables in both StorageServiceMBean and > CFSMbean > * Allow a quicker token check without doing an extended verify > * Introduce an ImportOptions class to avoid passing in 100 booleans in > importNewSSTables -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org