[ 
https://issues.apache.org/jira/browse/CASSANDRA-14447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478141#comment-16478141
 ] 

Ariel Weisberg commented on CASSANDRA-14447:
--------------------------------------------

The code changes look good. There are a lot of test failures in the dtests. 
Someone has to dig through and say that they are unrelated. Maybe run the 
unmodified branches and post the results so we can see where things stand 
without these changes.

> Cleanup StartupClusterConnectivityChecker and PING Verb
> -------------------------------------------------------
>
>                 Key: CASSANDRA-14447
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14447
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
>             Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> This is a followup to CASSANDRA-13993. After an internal review, 
> [~iamaleksey] had some concerns wrt to the VERB choices as was committed; 
> this was discussed on CASSANDRA-13993, after commit. Further, he pointed out 
> (and provided) some optimizations for {{StartupClusterConnectivityChecker}} 
> itself. While testing some of the proposed changes, I also discovered a small 
> bug where the timeout for waiting for the response to the PING message was 
> dramtically shorter than the overall timeout that is configured for 
> {{StartupClusterConnectivityChecker}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to