[ https://issues.apache.org/jira/browse/CASSANDRA-14488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499073#comment-16499073 ]
Jason Brown edited comment on CASSANDRA-14488 at 6/2/18 1:43 PM: ----------------------------------------------------------------- Patch lgtm, although I cleaned up some white space (removed tabs, aligned indentation). Ran the tests and everything checks out: ||trunk|| |[branch|https://github.com/jasobrown/cassandra/tree/14488-trunk]| |[utests & dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14488-trunk]| committed as sha \{[4d8fc5b050efaef3da818605c31e62b508425972}}. Thanks for the patch, [~benoitw]! This closes #231 was (Author: jasobrown): Patch lgtm, although I cleaned up some white space (removed tabs, aligned indentation). Ran the tests and everything checks out: ||trunk|| |[branch|https://github.com/jasobrown/cassandra/tree/14488-trunk]| |[utests & dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14488-trunk]| || committed as sha {[4d8fc5b050efaef3da818605c31e62b508425972}}. Thanks for the patch, [~benoitw]! > Avoid unneeded memory allocations / cpu for disabled log levels > --------------------------------------------------------------- > > Key: CASSANDRA-14488 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14488 > Project: Cassandra > Issue Type: Improvement > Reporter: Benoit Wiart > Assignee: Benoit Wiart > Priority: Minor > Fix For: 4.0 > > > add debug and trace log guard when the parameters creation implies memory > allocations and / or cpu. > Especially for StreamingInboundHandler/NettyStreamingMessageSender where > createLogTag is allocating 64*2+UUID#toString bytes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org