[ 
https://issues.apache.org/jira/browse/CASSANDRA-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509847#comment-16509847
 ] 

Sam Tunnicliffe edited comment on CASSANDRA-14513 at 6/12/18 4:42 PM:
----------------------------------------------------------------------

Trivial fix is to correctly adjust the current index pointer in IndexState when 
the slice bounds are found to be wholly before the start of the partition. It 
might make sense to open a follow up JIRA to investigate whether the 
modification of the tombstone bounds (in 
{{RangeTombstoneList::reverseIterator}}, and maybe {{forwardIterator}} if 
necessary) can be tightened up by asserting that any newly generated bounds are 
not disjoint from the query slice.
||branch||CircleCI||
|[3.0|https://github.com/beobal/cassandra/tree/14513-3.0]|[circle|https://circleci.com/workflow-run/16abca6e-d7e8-4671-aaeb-4f9de32b8190]|
|[3.11|https://github.com/beobal/cassandra/tree/14513-3.11]|[circle|https://circleci.com/workflow-run/7c79b1d7-26db-436f-b156-cdf05284b85a]|
|[trunk|https://github.com/beobal/cassandra/tree/14513-4.0]|[circle|https://circleci.com/workflow-run/076bf598-8a40-4637-9de2-f936c62f8863]|

 CI runs are using [~iamaleksey]'s dtest branch mentioned in the previous 
comment.


was (Author: beobal):
Trivial fix is to correctly adjust the current index pointer in IndexState when 
the slice bounds are found to be wholly before the start of the partition. It 
might make sense to open a follow up JIRA to investigate whether the 
modification of the tombstone bounds (in 
{{RangeTombstoneList::reverseIterator}}, and maybe {{forwardIterator}} if 
necessary) can be tightened up by asserting that any newly generated bounds are 
not disjoint from the query slice.

||branch||CircleCI||
|[3.0|https://github.com/beobal/cassandra/tree/14513-3.0]|[circle|https://circleci.com/workflow-run/16abca6e-d7e8-4671-aaeb-4f9de32b8190]|
|[3.11|https://github.com/beobal/cassandra/tree/14513-3.11]|[circle|https://circleci.com/workflow-run/7c79b1d7-26db-436f-b156-cdf05284b85a]|
|[trunk|https://github.com/beobal/cassandra/tree/14513-4.0]|[circle|https://circleci.com/workflow-run/076bf598-8a40-4637-9de2-f936c62f8863]|


 

> Reverse order queries in presence of range tombstones may cause permanent 
> data loss
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14513
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14513
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core, CQL, Local Write-Read Paths
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Blocker
>             Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> Slice queries in descending sort order can create oversized artificial range 
> tombstones. At CL > ONE, read repair can propagate these tombstones to all 
> replicas, wiping out vast data ranges that they mistakenly cover.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to