Sam Tunnicliffe updated CASSANDRA-14497:
    Fix Version/s: 4.0
           Status: Patch Available  (was: Open)

Sorry it's a bit late, but I found some time to get my patch tidied up. It goes 
a bit beyond the scope of the original description to ensure that all Role info 
can be served from the cache: login privilege, superuser status, custom role 
options as well as the member-of list.

> Add Role login cache
> --------------------
>                 Key: CASSANDRA-14497
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14497
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Auth
>            Reporter: Jay Zhuang
>            Assignee: Sam Tunnicliffe
>            Priority: Major
>              Labels: security
>             Fix For: 4.0
> The 
> [{{ClientState.login()}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/ClientState.java#L313]
>  function is used for all auth message: 
> [{{AuthResponse.java:82}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/AuthResponse.java#L82].
>  But the 
> [{{role.canLogin}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/auth/CassandraRoleManager.java#L521]
>  information is not cached. So it hits the database every time: 
> [{{CassandraRoleManager.java:407}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/auth/CassandraRoleManager.java#L407].
>  For a cluster with lots of new connections, it's causing performance issue. 
> The mitigation for us is to increase the {{system_auth}} replication factor 
> to match the number of nodes, so 
> [{{local_one}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/auth/CassandraRoleManager.java#L488]
>  would be very cheap. The P99 dropped immediately, but I don't think it is 
> not a good solution.
> I would purpose to add {{Role.canLogin}} to the RolesCache to improve the 
> auth performance.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to