[
https://issues.apache.org/jira/browse/CASSANDRA-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513964#comment-16513964
]
Joel Knighton commented on CASSANDRA-13692:
-------------------------------------------
Thanks again for the patch. I apologize for my genuinely staggering lateness
here; you deserve better. Some thoughts:
* On all versions, I don't think we'll actually hit the error handling here.
In CASSANDRA-9669, we pushed error handling down into {{getWriteableLocation}}
so that callers don't need to check for null and throw an exception themselves.
* On 2.2, in the error-handling, we still throw a {{RuntimeException}} from
within {{getWriteableLocation}}. I think this probably remains the right thing
to do. in CASSANDRA-11828, for 3.0+, we switched to throwing an
{{FSWriteError}} from {{getWriteableLocation}}. This caused the behavior in
CASSANDRA-12385 which we fixed by adding an {{FSDiskFullWriteError}} that we
throw instead and handle in ACT. I think backporting all that to 2.2 is
probably unnecessary given the age of 2.2.
Am I missing a situation in which we'd hit this error handling? It really seems
to me that we longer return null from {{getWriteableLocation}}. If I'm not, I
think the best thing to do is update the javadocs of affected methods and
remove the unused error handling from {{CompactionAwareWriter}}.
> CompactionAwareWriter_getWriteDirectory throws incompatible exceptions
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-13692
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13692
> Project: Cassandra
> Issue Type: Bug
> Components: Compaction
> Reporter: Hao Zhong
> Assignee: Dimitar Dimitrov
> Priority: Major
> Labels: lhf
> Attachments: c13692-2.2-dtest-results.PNG,
> c13692-2.2-testall-results.PNG, c13692-3.0-dtest-results-updated.PNG,
> c13692-3.0-dtest-results.PNG, c13692-3.0-testall-results.PNG,
> c13692-3.11-dtest-results-updated.PNG, c13692-3.11-dtest-results.PNG,
> c13692-3.11-testall-results.PNG, c13692-dtest-results-updated.PNG,
> c13692-dtest-results.PNG, c13692-testall-results-updated.PNG,
> c13692-testall-results.PNG
>
>
> The CompactionAwareWriter_getWriteDirectory throws RuntimeException:
> {code}
> public Directories.DataDirectory getWriteDirectory(Iterable<SSTableReader>
> sstables, long estimatedWriteSize)
> {
> File directory = null;
> for (SSTableReader sstable : sstables)
> {
> if (directory == null)
> directory = sstable.descriptor.directory;
> if (!directory.equals(sstable.descriptor.directory))
> {
> logger.trace("All sstables not from the same disk - putting
> results in {}", directory);
> break;
> }
> }
> Directories.DataDirectory d =
> getDirectories().getDataDirectoryForFile(directory);
> if (d != null)
> {
> long availableSpace = d.getAvailableSpace();
> if (availableSpace < estimatedWriteSize)
> throw new RuntimeException(String.format("Not enough space to
> write %s to %s (%s available)",
>
> FBUtilities.prettyPrintMemory(estimatedWriteSize),
> d.location,
>
> FBUtilities.prettyPrintMemory(availableSpace)));
> logger.trace("putting compaction results in {}", directory);
> return d;
> }
> d = getDirectories().getWriteableLocation(estimatedWriteSize);
> if (d == null)
> throw new RuntimeException(String.format("Not enough disk space
> to store %s",
>
> FBUtilities.prettyPrintMemory(estimatedWriteSize)));
> return d;
> }
> {code}
> However, the thrown exception does not trigger the failure policy.
> CASSANDRA-11448 fixed a similar problem. The buggy code is:
> {code}
> protected Directories.DataDirectory getWriteDirectory(long writeSize)
> {
> Directories.DataDirectory directory =
> getDirectories().getWriteableLocation(writeSize);
> if (directory == null)
> throw new RuntimeException("Insufficient disk space to write " +
> writeSize + " bytes");
> return directory;
> }
> {code}
> The fixed code is:
> {code}
> protected Directories.DataDirectory getWriteDirectory(long writeSize)
> {
> Directories.DataDirectory directory =
> getDirectories().getWriteableLocation(writeSize);
> if (directory == null)
> throw new FSWriteError(new IOException("Insufficient disk space
> to write " + writeSize + " bytes"), "");
> return directory;
> }
> {code}
> The fixed code throws FSWE and triggers the failure policy.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
