[
https://issues.apache.org/jira/browse/CASSANDRA-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528880#comment-16528880
]
Jason Brown edited comment on CASSANDRA-9608 at 6/30/18 8:10 PM:
-----------------------------------------------------------------
Added more comments to the PR, and have the following:
* JMXServerUtils - I'm not sure sure what to do with this one. I'm not
thrilled with just using reflection to get at an instance of
{{JMXPluggableAuthenticator}}, expecially when the behavior it provides doesn't
appear to be anything special. Further, it looks like {{AuthenticationProxy}}
does most of the same functionality anyway. That being said, I am not a
JMX/JAAS expert in any way, and I'd love [~beobal]'s input on whether we could
eliminate {{JMXPluggableAuthenticatorWrapper}} in lieu of something similar to
{{AuthenticationProxy}}. This being said, I would be OK-ish if we stick with
the existing {{JMXPluggableAuthenticator}} as it ties directly into the jdk's
JMX subsystem and changes that happen there we would just get out of the box,
rather than needing to attempt feature parity with it.
* build.xml - we used to reference the jdkoverride in the javac step of the
{{build}} task. That seems to have been lost from the current build.xml file.
Further, it's not entirely clear to me what that jdkoverride is actually doing,
particularly in the java compilation step. I'll look into purpose of the sole
class in that directory, CRC32.class
Review ongoing ...
was (Author: jasobrown):
Added more comments to the PR, and have the following:
* JMXServerUtils - I'm not sure sure what to do with this one. I'm not
thrilled with just using reflection to get at an instance of
{{JMXPluggableAuthenticator}}, expecially when the behavior it provides doesn't
appear to be anything special. Further, it looks like {{AuthenticationProxy}}
does most of the same functionality anyway. That being said, I am not a
JMX/JAAS expert in any way, and I'd love [~beobal]'s input on whether we could
eliminate {{JMXPluggableAuthenticatorWrapper}} in lieu of something similar to
{{AuthenticationProxy}}. This being said, I would be OK-ish if we stick with
the existing {{JMXPluggableAuthenticator}} as it ties directly into the jdk's
JMX subsystem and changes that happen there we would just get out of the box,
rather than needing to attempt feature parity with it.
Review ongoing ...
> Support Java 11
> ---------------
>
> Key: CASSANDRA-9608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9608
> Project: Cassandra
> Issue Type: Task
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
> Fix For: 4.x
>
> Attachments: jdk_9_10.patch
>
>
> This ticket is intended to group all issues found to support Java 9 in the
> future.
> From what I've found out so far:
> * Maven dependency {{com.sun:tools:jar:0}} via cobertura cannot be resolved.
> It can be easily solved using this patch:
> {code}
> - <dependency groupId="net.sourceforge.cobertura"
> artifactId="cobertura"/>
> + <dependency groupId="net.sourceforge.cobertura"
> artifactId="cobertura">
> + <exclusion groupId="com.sun" artifactId="tools"/>
> + </dependency>
> {code}
> * Another issue is that {{sun.misc.Unsafe}} no longer contains the methods
> {{monitorEnter}} + {{monitorExit}}. These methods are used by
> {{o.a.c.utils.concurrent.Locks}} which is only used by
> {{o.a.c.db.AtomicBTreeColumns}}.
> I don't mind to start working on this yet since Java 9 is in a too early
> development phase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
