[
https://issues.apache.org/jira/browse/CASSANDRA-14443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529755#comment-16529755
]
Kurt Greaves commented on CASSANDRA-14443:
------------------------------------------
Sorry for the delay... Finally got a chance to get back to this.
Thanks heaps for the review [~jrwest]
So while addressing your comments I did some further cleaning up and got rid of
the {{--skip-resource-intensive-tests}} arg, as it appears to be completely
pointless. Resource intensive options all default to False, so there's never a
real need to explicitly skip them.
{quote}How about exiting instead of logging a warning when insufficient
resources are available for running resource intensive tests
(conftest.py#L460), unless --force-resource-intensive-tests is set? Behaviour
would be unchanged otherwise and users who want to force run only the resource
intensive tests on insufficient hardware can use
-force-resource-intensive-tests --resource-intensive-tests-only.
{quote}
I personally think this is just annoying. TBH I think that the whole resource
check can go, and this kind of information is more suitable for the
documentation. We don't put resource limits on Cassandra and I don't think we
should do it for the dtests. If people want to run it without enough resources,
by all means let them, they'll quickly find out what's wrong.
To clarify, I don't think we have to be so user friendly that we stop people
doing things that might not work, but I do think we should avoid having to
string together series of massive arguments. The config for running the dtests
at the moment is pretty complicated, and I think we can do away with some of
that.
Having said that, I don't think what I have in this patch is perfect. In fact
some serious refactoring needs to be done around the whole test selection
business, but that's not going to happen for a while and I'm hoping this will
at least make it a bit more usable in the meantime.
{quote} run_dtests.py: some things I noticed that may be worth cleaning up
while we’re here
1. original_raw_cmd_args is only used in one place now. Consider removing it.
2. comment on line 120 is stale{quote}
Fixed
Updated branch is
[here|https://github.com/apache/cassandra-dtest/compare/master...kgreav:14443]
> Improvements for running dtests
> -------------------------------
>
> Key: CASSANDRA-14443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14443
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
> Reporter: Kurt Greaves
> Assignee: Kurt Greaves
> Priority: Major
> Labels: dtest
>
> We currently hardcode a requirement that you need at least 27gb of memory to
> run the resource intensive tests. This is rather annoying as there isn't
> really a strict hardware requirement and tests can run on smaller machines in
> a lot of cases (especially if you mess around with HEAP).
> We've already got the command line argument
> {{--force-resource-intensive-tests}}, we don't need additional restrictions
> in place to stop people who shouldn't be running the tests from running them.
> We also don't have a way to run _only_ the resource-intensive dtests or
> _only_ the upgrade tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
