[
https://issues.apache.org/jira/browse/CASSANDRA-14443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530727#comment-16530727
]
Jordan West edited comment on CASSANDRA-14443 at 7/3/18 2:30 AM:
-----------------------------------------------------------------
Thanks for the updates [~KurtG].
Some comments from a second pass:
* conftest.pyL434 should be {{if not}} instead of {{if sufficient_…}},
otherwise the logging occurs in the wrong case
* Looking at the docs you added, conftest.pyL479 be {{if not upgrade and not
upgrade_only}}, similar to L445 for resource intensive flags
* Is it intentional to use {{print}} instead of the loggers in conftest.py?
conftest.pyL492 may also be verbose. Similarly, run_dtests.py was changed to
use loggers instead of {{print}} on L73.
{quote}TBH I think that the whole resource check can go, and this kind of
information is more suitable for the documentation. We don't put resource
limits on Cassandra and I don't think we should do it for the dtests.
{quote}
Logging is useful because it reduces the amount of time to find the issue and
fix it. Failing fast, with an option to override, speeds that up more but I'm
not strongly for it, if you prefer to leave it as is.
was (Author: jrwest):
Thanks for the updates [~KurtG].
S}ome comments from a second pass:
* conftest.pyL434 should be {{if not}} instead of {{if sufficient_…}},
otherwise the logging occurs in the wrong case
* Looking at the docs you added, conftest.pyL479 be {{if not upgrade and not
upgrade_only}}, similar to L445 for resource intensive flags
* Is it intentional to use {{print}} instead of the loggers in conftest.py?
conftest.pyL492 may also be verbose. Similarly, run_dtests.py was changed to
use loggers instead of {{print}} on L73.
{quote}TBH I think that the whole resource check can go, and this kind of
information is more suitable for the documentation. We don't put resource
limits on Cassandra and I don't think we should do it for the dtests.
{quote}
Logging is useful because it reduces the amount of time to find the issue and
fix it. Failing fast, with an option to override, speeds that up more but I'm
not strongly for it, if you prefer to leave it as is.
> Improvements for running dtests
> -------------------------------
>
> Key: CASSANDRA-14443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14443
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
> Reporter: Kurt Greaves
> Assignee: Kurt Greaves
> Priority: Major
> Labels: dtest
>
> We currently hardcode a requirement that you need at least 27gb of memory to
> run the resource intensive tests. This is rather annoying as there isn't
> really a strict hardware requirement and tests can run on smaller machines in
> a lot of cases (especially if you mess around with HEAP).
> We've already got the command line argument
> {{--force-resource-intensive-tests}}, we don't need additional restrictions
> in place to stop people who shouldn't be running the tests from running them.
> We also don't have a way to run _only_ the resource-intensive dtests or
> _only_ the upgrade tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
