[ 
https://issues.apache.org/jira/browse/CASSANDRA-14523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563229#comment-16563229
 ] 

Chris Lohfink commented on CASSANDRA-14523:
-------------------------------------------

Removed scheduled thread pools and applied some of changes. I feel the dynamic 
tables and the local partitioner changes can be pulled off in different ticket 
as its a lot of refactoring things in way thats not necessary here. We can 
fetch the metrics through registry but I kinda like doing it same way as 
nodetool as it is pretty simple and low impact.

Included change to make thread names camel case. It looks bad imho since we are 
not even constant in code, sometimes even using camel case with dashes:

{code}
 thread_pool                      | active | active_max | completed | pending | 
tasks_blocked | total_blocked
----------------------------------+--------+------------+-----------+---------+---------------+---------------
          memtable_reclaim_memory |      0 |          1 |         1 |       0 | 
            0 |             0
                      repair_task |      0 | 2147483647 |         0 |       0 | 
            0 |             0
            memtable_flush_writer |      0 |          2 |         1 |       0 | 
            0 |             0
           request_response_stage |      0 |          8 |         0 |       0 | 
            0 |             0
                read_repair_stage |      0 |          8 |         0 |       0 | 
            0 |             0
              compaction_executor |      0 |          2 |        47 |       0 | 
            0 |             0
                   mutation_stage |      0 |         32 |         0 |       0 | 
            0 |             0
                       read_stage |      0 |         32 |        12 |       0 | 
            0 |             0
                          sampler |      0 |          1 |         0 |       0 | 
            0 |             0
               anti_entropy_stage |      0 |          1 |         0 |       0 | 
            0 |             0
 per_disk_memtable_flush_writer_0 |      0 |          2 |         1 |       0 | 
            0 |             0
           cache_cleanup_executor |      0 |          1 |         0 |       0 | 
            0 |             0
              validation_executor |      0 | 2147483647 |         0 |       0 | 
            0 |             0
                       misc_stage |      0 |          1 |         0 |       0 | 
            0 |             0
           counter_mutation_stage |      0 |         32 |         0 |       0 | 
            0 |             0
        native_transport_requests |      1 |        128 |        28 |       0 | 
            0 |             0
          internal_response_stage |      0 |          8 |         0 |       0 | 
            0 |             0
                  migration_stage |      0 |          1 |         0 |       0 | 
            0 |             0
                     gossip_stage |      0 |          1 |         0 |       0 | 
            0 |             0
              memtable_post_flush |      0 |          1 |         2 |       0 | 
            0 |             0
         pending_range_calculator |      0 |          1 |         2 |       0 | 
            0 |             0
              view_mutation_stage |      0 |         32 |         0 |       0 | 
            0 |             0
                 hints_dispatcher |      0 |          2 |         0 |       0 | 
            0 |             0
              view_build_executor |      0 |          1 |         0 |       0 | 
            0 |             0
       secondary_index_management |      0 |          1 |         0 |       0 | 
            0 |             0

(25 rows)


 thread_pool                  | active | active_max | completed | pending | 
tasks_blocked | total_blocked
------------------------------+--------+------------+-----------+---------+---------------+---------------
              HintsDispatcher |      0 |          2 |         0 |       0 |     
        0 |             0
           CompactionExecutor |      0 |          2 |        47 |       0 |     
        0 |             0
           ValidationExecutor |      0 | 2147483647 |         0 |       0 |     
        0 |             0
                  GossipStage |      0 |          1 |         0 |       0 |     
        0 |             0
         CounterMutationStage |      0 |         32 |         0 |       0 |     
        0 |             0
                MutationStage |      0 |         32 |         0 |       0 |     
        0 |             0
               MigrationStage |      0 |          1 |         0 |       0 |     
        0 |             0
            ViewBuildExecutor |      0 |          1 |         0 |       0 |     
        0 |             0
            ViewMutationStage |      0 |         32 |         0 |       0 |     
        0 |             0
    Native-Transport-Requests |      1 |        128 |        48 |       0 |     
        0 |             0
         CacheCleanupExecutor |      0 |          1 |         0 |       0 |     
        0 |             0
         RequestResponseStage |      0 |          8 |         0 |       0 |     
        0 |             0
        MemtableReclaimMemory |      0 |          1 |         1 |       0 |     
        0 |             0
        InternalResponseStage |      0 |          8 |         0 |       0 |     
        0 |             0
              ReadRepairStage |      0 |          8 |         0 |       0 |     
        0 |             0
 PerDiskMemtableFlushWriter_0 |      0 |          2 |         1 |       0 |     
        0 |             0
       PendingRangeCalculator |      0 |          1 |         2 |       0 |     
        0 |             0
            MemtablePostFlush |      0 |          1 |         2 |       0 |     
        0 |             0
                    MiscStage |      0 |          1 |         0 |       0 |     
        0 |             0
          MemtableFlushWriter |      0 |          2 |         1 |       0 |     
        0 |             0
             AntiEntropyStage |      0 |          1 |         0 |       0 |     
        0 |             0
                  Repair-Task |      0 | 2147483647 |         0 |       0 |     
        0 |             0
                      Sampler |      0 |          1 |         0 |       0 |     
        0 |             0
                    ReadStage |      0 |         32 |        13 |       0 |     
        0 |             0
     SecondaryIndexManagement |      0 |          1 |         0 |       0 |     
        0 |             0
{code}

> Thread pool stats virtual table
> -------------------------------
>
>                 Key: CASSANDRA-14523
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14523
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Chris Lohfink
>            Assignee: Chris Lohfink
>            Priority: Minor
>              Labels: virtual-tables
>
> Expose the thread pools like in status logger/tpstats. Additionally be nice 
> to include the scheduled executor pools that are currently unmonitored.
> {code:java}
> cqlsh> select * from system_views.thread_pools;
>  thread_pool                      | active | active_max | completed | pending 
> | tasks_blocked | total_blocked
> ----------------------------------+--------+------------+-----------+---------+---------------+---------------
>                anti_entropy_stage |      0 |          1 |         0 |       0 
> |             0 |             0
>            cache_cleanup_executor |      0 |          1 |         0 |       0 
> |             0 |             0
>               compaction_executor |      0 |          4 |        41 |       0 
> |             0 |             0
>            counter_mutation_stage |      0 |         32 |         0 |       0 
> |             0 |             0
>                      gossip_stage |      0 |          1 |         0 |       0 
> |             0 |             0
>                  hints_dispatcher |      0 |          2 |         0 |       0 
> |             0 |             0
>           internal_response_stage |      0 |          8 |         0 |       0 
> |             0 |             0
>             memtable_flush_writer |      0 |          2 |         5 |       0 
> |             0 |             0
>               memtable_post_flush |      0 |          1 |        20 |       0 
> |             0 |             0
>           memtable_reclaim_memory |      0 |          1 |         5 |       0 
> |             0 |             0
>                   migration_stage |      0 |          1 |         0 |       0 
> |             0 |             0
>                        misc_stage |      0 |          1 |         0 |       0 
> |             0 |             0
>                    mutation_stage |      0 |         32 |       247 |       0 
> |             0 |             0
>         native_transport_requests |      1 |        128 |        28 |       0 
> |             0 |             0
>          pending_range_calculator |      0 |          1 |         2 |       0 
> |             0 |             0
>  per_disk_memtable_flush_writer_0 |      0 |          2 |         5 |       0 
> |             0 |             0
>                 read_repair_stage |      0 |          8 |         0 |       0 
> |             0 |             0
>                        read_stage |      0 |         32 |        13 |       0 
> |             0 |             0
>                       repair_task |      0 | 2147483647 |         0 |       0 
> |             0 |             0
>            request_response_stage |      0 |          8 |         0 |       0 
> |             0 |             0
>                           sampler |      0 |          1 |         0 |       0 
> |             0 |             0
>              scheduled_fast_tasks |      0 | 2147483647 |      1398 |       1 
> |             0 |             0
>               scheduled_heartbeat |      0 | 2147483647 |        14 |       1 
> |             0 |             0
>         scheduled_hotness_tracker |      0 | 2147483647 |         0 |       1 
> |             0 |             0
>      scheduled_non_periodic_tasks |      0 | 2147483647 |        10 |       0 
> |             0 |             0
>          scheduled_optional_tasks |      0 | 2147483647 |         5 |       8 
> |             0 |             0
>         scheduled_summary_builder |      0 | 2147483647 |         0 |       1 
> |             0 |             0
>                   scheduled_tasks |      0 | 2147483647 |       194 |      74 
> |             0 |             0
>        secondary_index_management |      0 |          1 |         0 |       0 
> |             0 |             0
>               validation_executor |      0 | 2147483647 |         0 |       0 
> |             0 |             0
>               view_build_executor |      0 |          1 |         0 |       0 
> |             0 |             0
>               view_mutation_stage |      0 |         32 |         0 |       0 
> |             0 |             0
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to