[ https://issues.apache.org/jira/browse/CASSANDRA-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581223#comment-16581223 ]
Jason Brown edited comment on CASSANDRA-14574 at 8/15/18 3:21 PM: ------------------------------------------------------------------ [~djoshi3] Thanks for reviewing. I agree with the changes you've proposed (nice find on the {{ByteBuf.skipBytes()}}), and have cherry picked the two commits from your branch and rerun the tests: ||14574|| |[branch|https://github.com/jasobrown/cassandra/tree/14574]| |[utests & dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14574]| || Working on a dtest now; not so straight-forward, but can be done. was (Author: jasobrown): [~djoshi3] Thanks for reviewing. I agree with the changes you've proposed (nice find on the {{ByteBug.skipBytes()}}), and have cherry picked the two commits from your branch and rerun the tests: ||14574|| |[branch|https://github.com/jasobrown/cassandra/tree/14574]| |[utests & dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14574]| || Working on a dtest now; not so straight-forward, but can be done. > Incomplete handling of exceptions when decoding incoming messages > ------------------------------------------------------------------ > > Key: CASSANDRA-14574 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14574 > Project: Cassandra > Issue Type: Bug > Components: Streaming and Messaging > Reporter: Aleksey Yeschenko > Assignee: Jason Brown > Priority: Major > Fix For: 4.0 > > > {{MessageInHandler.decode()}} occasionally reads the payload incorrectly, > passing the full message to {{MessageIn.read()}} instead of just the payload > bytes. > You can see the stack trace in the logs from this [CI > run|https://circleci.com/gh/iamaleksey/cassandra/437#tests/containers/38]. > {code} > Caused by: java.lang.AssertionError: null > at > org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:351) > at > org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:371) > at > org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:335) > at org.apache.cassandra.net.MessageIn.read(MessageIn.java:158) > at > org.apache.cassandra.net.async.MessageInHandler.decode(MessageInHandler.java:132) > {code} > Reconstructed, truncated stream passed to {{MessageIn.read()}}: > {{0000000b000743414c5f42414301002a01e1a5c9b089fd11e8b517436ee1243007040000005d10fc50ec}} > You can clearly see parameters in there encoded before the payload: > {{[43414c5f424143 - CAL_BAC] [01 - ONE_BYTE] [002a - 42, payload size] 01 e1 > a5 c9 b0 89 fd 11 e8 b5 17 43 6e e1 24 30 07 04 00 00 00 1d 10 fc 50 ec}} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org