[
https://issues.apache.org/jira/browse/CASSANDRA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582658#comment-16582658
]
Ariel Weisberg commented on CASSANDRA-14648:
--------------------------------------------
bq. Well, that isn't a very good citizen approach IMO. For starters, we
shouldn't have flakey tests, and this would encourage us to fix them. It's also
trivial to manually kick off the dtests if the failed unit tests are inspected
to be OK.
That assumes a failed unit tests means dtests are also going to just implode
and not bear information and IME it's rarely true.
bq. I'd personally prefer we only ran dtests on a manual request, as they
should only be needed a fraction of the frequency I think they're requested.
This is an orthogonal concern and I do agree with it. I usually end up killing
a lot of CircleCI runs spawned automatically due to git activity.
Have you been having trouble getting your stuff run? I feel like I have never
waited for containers.
Is it actually possible to get the dtests to run manually if the code in your
branch is checked and says "don't run the dtests"? Does it even create the jobs
for that commit for you?
> CircleCI dtest runs should (by default) depend upon successful unit tests
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-14648
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14648
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Benedict
> Assignee: Benedict
> Priority: Major
>
> Unit tests are very quick to run, and if they fail to pass there’s probably
> no value in running dtests - particularly if we are honouring our
> expectations of never committing code that breaks either unit or dtests.
> When sharing CircleCI resources between multiple branches (or multiple
> users), it is wasteful to have two dtest runs kicked off for every incomplete
> branch that is pushed to GitHub for safe keeping. So I think a better
> default CircleCI config file would only run the dtests after a successful
> unit test run, and those who want to modify this behaviour can do so
> consciously by editing the config file for themselves.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
