[ 
https://issues.apache.org/jira/browse/CASSANDRA-14621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589934#comment-16589934
 ] 

Marcus Eriksson commented on CASSANDRA-14621:
---------------------------------------------

+1

seems you didn't push the latest fix to circle, but the failing test passes for 
me locally on the non-{{cci/csm-refactor}} branch

> Refactor CompactionStrategyManager
> ----------------------------------
>
>                 Key: CASSANDRA-14621
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14621
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 4.x
>
>
> CompactionStrategyManager grew a decent amount of duplicated code as part of 
> CASSANDRA-9143, which added pendingRepairs alongside the repaired and 
> unrepaired buckets. At this point, the logic that routes sstables between the 
> different buckets, and the different partition range divisions has gotten a 
> little complex, and editing it is tedious and error prone. With transient 
> replication requiring yet another bucket for, this seems like a good time to 
> split some of the functionality of CSM into other classes, and make sstable 
> routing a bit more generalized.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to