[ https://issues.apache.org/jira/browse/CASSANDRA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590152#comment-16590152 ]
Marcus Olsson commented on CASSANDRA-14659: ------------------------------------------- [~djoshi3], sure, as I said I don't really have a strong opinion on this and I think it would be useful as you said to have a test of client connections before performing a major upgrade. I haven't tested/verified the patches but I did glance over them and found a few small things: * In the nodetool command for [DisableOldProtocolVersions|https://github.com/dineshjoshi/cassandra/blob/73f921d7f981f0be1efe688c6d02968eb784a15b/src/java/org/apache/cassandra/tools/nodetool/DisableOldProtocolVersions.java#L25] the description is "Enable old protocol versions" rather than "Disable old protocol versions". * In the dtest I think it would be good to have a verification that it's still possible to connect with the latest protocol version in between disabling/enabling the feature. > Disable old protocol versions on demand > --------------------------------------- > > Key: CASSANDRA-14659 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14659 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Dinesh Joshi > Assignee: Dinesh Joshi > Priority: Major > Labels: usability > > This patch allows the operators to disable older protocol versions on demand. > To use it, you can set {{native_transport_allow_older_protocols}} to false or > use nodetool disableolderprotocolversions. Cassandra will reject requests > from client coming in on any version except the current version. This will > help operators selectively reject connections from clients that do not > support the latest protoocol. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org