[
https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597130#comment-16597130
]
Dinesh Joshi commented on CASSANDRA-14677:
------------------------------------------
{quote}I think it would be helpful for committers and for future reviewers to
have a better understanding of what is meant by "big mess". Perhaps you could
update the description to better outline the specific issues with the execute()
method implementations. This would also make the changes in the patch more
clear for review.
{quote}
+1
[~iamaleksey] From my reading of your patch, you have refactored code into
small, concise blocks which is great. For future reference it would be helpful
for the whole community if we have a set of best practices that we should all
follow. Perhaps they could be part of the contribution guidelines. It will help
all reviewers enforce these best practices. I would be happy to work with you
and other folks to draft this up and review it with a wider audience. It will
only help us deliver better quality patches, consistently. WDYT?
I have not deep dived into the patch but I also noticed you renamed
{{execute()}} to {{perform()}}. AFAICT they're synonyms. I am curious about the
choice of name as well.
> Clean up Message.Request implementations
> ----------------------------------------
>
> Key: CASSANDRA-14677
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14677
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Fix For: 4.0.x
>
>
> First tracing support, many years ago, then most recently audit log, made a
> big mess out of {{Message.Request.execute()}} implementations.
> This patch tries to clean up some of it by removing tracing logic from
> {{QueryState}} and moving shared tracing functionality to
> {{Message.Request.perform()}}. It also moves out tracing and audit log boiler
> plate into their own small methods instead of polluting {{execute()}}
> implementations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
