[
https://issues.apache.org/jira/browse/CASSANDRA-14619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599273#comment-16599273
]
Jason Brown commented on CASSANDRA-14619:
-----------------------------------------
- ColumnDefsReader.readMarshallable - you read an int32 value, but in
ColumnDefsWriter.writeMarshallable, you wrote an int16. Is this correct? The
unit tests pass, but I'm not sure if RecordStore is being fully exercised. The
same thing happens in RowReader vs RowWriter
UPDATE: I stepped through the chronicle code and it looks like the library can
optimize the value it writes out (it only gets written as a byte, basically,
since your value is zero). So, while your API calls are incongruous, the
library does a correct thing under the hood. I would still prefer you to switch
to the reads to int16(), but that can be done on commit.
I also had a few trivial comments on the PR linked above. They are minor, so
just address them on commit (if you choose).
Otherwise, +1 from me.
> Create fqltool compare command
> ------------------------------
>
> Key: CASSANDRA-14619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14619
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Major
> Labels: fqltool
> Fix For: 4.x
>
>
> We need a {{fqltool compare}} command that can take the recorded runs from
> CASSANDRA-14618 and compares them, it should output any differences and
> potentially all queries against the mismatching partition up until the
> mismatch
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
