[ 
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625857#comment-16625857
 ] 

Joshua McKenzie commented on CASSANDRA-14772:
---------------------------------------------

I wouldn't consider a refactor to be a bug-fix. While there's a small minority 
of this ticket that's defect-related, I think committing a refactor post-freeze 
date for 4.0 is not good hygiene.

Am I missing something here?

> Refactor audit / full query log
> -------------------------------
>
>                 Key: CASSANDRA-14772
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14772
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 4.0
>
>
> I find the audit + full query log code quite hard to follow with some of the 
> naming and mixing of concepts, this ticket aims to:
> * move full query log specific code to a separate package 
> * do some audit log class renames (I keep reading {{BinLogAuditLogger}} vs 
> {{BinAuditLogger}} wrong for example)
> * avoid parsing the CQL queries twice in {{QueryMessage}} when audit log is 
> enabled.
> * add a new tool to dump audit logs (ie, let fqltool be full query log 
> specific)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to