[
https://issues.apache.org/jira/browse/CASSANDRA-14742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629970#comment-16629970
]
Benedict edited comment on CASSANDRA-14742 at 9/27/18 8:59 AM:
---------------------------------------------------------------
Thanks.
I'm a little concerned about the inconsistency of our
{{DatabaseDescriptor.getLocalDataCenter}} and this
{{IEndpointSnitch.getLocalDataCenter}}. I had intended to simply refer to the
former (although, debatably, only the latter should exist - since the former is
not consistently updated, although it should for correctness never change).
I'm honestly not clear what the best clean up of this mess is, particularly
with the distinction between the per-replication strategy snitch and the global
snitch (the former of which seem to simply cache the latter), and perhaps it
can be deferred to a later dedicated cleanup ticket anyway.
Otherwise, +1
was (Author: benedict):
Thanks.
I'm a little concerned about the inconsistency of our
{{DatabaseDescriptor.getLocalDataCenter}} and this
{{IEndpointSnitch.getLocalDataCenter}}. I had intended to simply refer to the
former (although, debatably, only the latter should exist - since the former is
not consistently updated, although it should for correctness never change).
I'm honestly not clear what the best clean up of this mess is, particularly
with the distinction between the per-replication strategy snitch and the global
snitch (the former of which seem to simply cache the latter), and perhaps it
can be deferred to a later dedicated cleanup ticket anyway.
> Race Condition in batchlog replica collection
> ---------------------------------------------
>
> Key: CASSANDRA-14742
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14742
> Project: Cassandra
> Issue Type: Bug
> Reporter: Alex Petrov
> Assignee: Alex Petrov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When we collect nodes for it in {{StorageProxy#getBatchlogReplicas}}, we
> already filter out down replicas; subsequently they get picked up and taken
> for liveAndDown.
> There's a possible race condition due to picking tokens from token metadata
> twice (once in {{StorageProxy#getBatchlogReplicas}} and second one in
> {{ReplicaPlan#forBatchlogWrite}})
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
