[
https://issues.apache.org/jira/browse/CASSANDRA-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630187#comment-16630187
]
Alex Petrov commented on CASSANDRA-14726:
-----------------------------------------
+1,
I have found only one tiny problem in tests
[here|https://github.com/apache/cassandra/pull/271#discussion-diff-220871785R173].
All other comments are nits.
Regarding tests themselves, I'm usually trying to make non-generic tests (e.g.
write hardcoded asserts rather than comparing outputs of functions), since
they're easier to read for reviewers. Not saying we should get rid of the ones
that are already there, but maybe we could at least add a comment or open a
jira to write some more "hardcoded" tests.
> ReplicaCollection follow-up
> ---------------------------
>
> Key: CASSANDRA-14726
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14726
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We introduced \{{ReplicaCollection}} as part of CASSANDRA-14404, but while it
> improves readability, we could do more to ensure it minimises extra garbage,
> and does not otherwise unnecessarily waste cycles.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
