[
https://issues.apache.org/jira/browse/CASSANDRA-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedict updated CASSANDRA-14726:
---------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Status: Resolved (was: Patch Available)
Thanks for the review. I've committed as
[e645b9172c5d50fc2af407de724e46121edfe109|https://github.com/apache/cassandra/commit/e645b9172c5d50fc2af407de724e46121edfe109].
dtests are now very flaky on CircleCI, but all of the failures in the latest
run have shown up in trunk runs for me on CircleCI.
As to tests, it's interesting that you find hard-coded tests to be easier to
read. I personally find the opposite. However, I'm happy to file a follow-up
JIRA to further expand the testing; I'll follow up with that in the near future.
> ReplicaCollection follow-up
> ---------------------------
>
> Key: CASSANDRA-14726
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14726
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Priority: Major
> Fix For: 4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We introduced \{{ReplicaCollection}} as part of CASSANDRA-14404, but while it
> improves readability, we could do more to ensure it minimises extra garbage,
> and does not otherwise unnecessarily waste cycles.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
