[
https://issues.apache.org/jira/browse/CASSANDRA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638181#comment-16638181
]
Jason Brown edited comment on CASSANDRA-14747 at 10/4/18 12:45 PM:
-------------------------------------------------------------------
Excellent find, [~jolynch].
Looks like we added the ability to set the send/recv buffer size in
CASSANDRA-3378 (which apparently I reviewed, 5.5 years ago). Looks like in 3.11
we [set the
SO_SNDBUF|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnection.java#L444]
if the operator provided a value in the yaml, but we did not set a default
value. However, it does appear I added a hard-coded default in 4.0 with
CASSANDRA-8457. As it's been nearly two years since I wrote that part of the
patch, I have no recollection of why I added a default. Removing it is trivial
and has huge benefits, as [~jolynch] has proven. I'm working on combining the
findings [~jolynch] and I have discovered over the last weeks and should have a
patch ready in a few days (which will probably be part CASSANDRA-14503, as most
of this work was based on that work-in-progress).
was (Author: jasobrown):
Excellent find, [~jolynch].
Looks like we added the ability to set the send/recv buffer size in
CASSANDRA-3378 (which apparently I reviewed, 5.5 years ago). Looks like in 3.11
we [set the
SO_SNDBUF|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnection.java#L444]
if the operator provided a value in the yaml, but we did not set a default
value. However, it does appear I added a hard-coded default in 4.0 with
CASSANDRA-8457. As it's been nearly two years since I wrote that part of the
patch, I have no recollection of why I added a default. Removing it is trivial
and has huge benefits, as has proven. I'm working on combining the findings
[~jolynch] and I have discovered over the last weeks and should have a patch
ready in a few days (which will probably be part CASSANDRA-14503, as most of
this work was based on that work-in-progress).
> Evaluate 200 node, compression=none, encryption=none, coalescing=off
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-14747
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14747
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Joseph Lynch
> Assignee: Joseph Lynch
> Priority: Major
> Attachments: 3.0.17-QPS.png, 4.0.1-QPS.png,
> 4.0.11-after-jolynch-tweaks.svg, 4.0.12-after-unconditional-flush.svg,
> 4.0.15-after-sndbuf-fix.svg, 4.0.7-before-my-changes.svg,
> 4.0_errors_showing_heap_pressure.txt,
> 4.0_heap_histogram_showing_many_MessageOuts.txt,
> i-0ed2acd2dfacab7c1-after-looping-fixes.svg,
> trunk_vs_3.0.17_latency_under_load.png,
> ttop_NettyOutbound-Thread_spinning.txt,
> useast1c-i-0e1ddfe8b2f769060-mutation-flame.svg,
> useast1e-i-08635fa1631601538_flamegraph_96node.svg,
> useast1e-i-08635fa1631601538_ttop_netty_outbound_threads_96nodes,
> useast1e-i-08635fa1631601538_uninlinedcpuflamegraph.0_96node_60sec_profile.svg
>
>
> Tracks evaluating a 200 node cluster with all internode settings off (no
> compression, no encryption, no coalescing).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
