[
https://issues.apache.org/jira/browse/CASSANDRA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638942#comment-16638942
]
Ariel Weisberg edited comment on CASSANDRA-14373 at 10/4/18 10:05 PM:
----------------------------------------------------------------------
Some quick review feedback.
* [Removing documentation of defaults doesn't seem like a pure win since they
still seem to be
there?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-e517aca4b5a9a4773e1957fa4574862aR26]
* [This isn't just a path right it's a format specified of sorts with
%path?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-e517aca4b5a9a4773e1957fa4574862aR44]
* [This is BinLogOptions but the comments reference Audit log and there is a
typo in the first sentence
here|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-8d9638dbfb056fb8020e9b32e60e3a61R33]
* Depending on what the archiving script does and why it failed there could be
unfortunate consequences to retrying repeatedly.
* [exec forks, forking can be slow because of page table copying which in the
past was slow under things like
Xen.|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR160].
I'm just mentioning it. I don't think you need to make it better right now. I
don't know offhand how you invoke an external command more efficiently from
Java.
* [Is this going to enable it for all
tests?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-b1c721618608f703239339811634ef3dR51]
Is that a good idea can we only enable it for just the unit tests that require
it?
* [Should use execute instead of submit unless consuming the result
future|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR77]
* [Same here |
https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR120]
I'll look at the dtests now.
was (Author: aweisberg):
Some quick review feedback.
* [Removing documentation of defaults doesn't seem like a pure win since they
still seem to be
there?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-e517aca4b5a9a4773e1957fa4574862aR26]
* [This isn't just a path right it's a format specified of sorts with
%path?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-e517aca4b5a9a4773e1957fa4574862aR44]
* [This is BinLogOptions but the comments reference Audit log and there is a
typo in the first sentence
here|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-8d9638dbfb056fb8020e9b32e60e3a61R33]
* Depending on what the archiving script does and why it failed there could be
unfortunate consequences to retrying repeatedly.
* [exec forks, forking can be slow because of page table copying which in the
was slow under things like
Xen.|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR160].
I'm just mentioning it. I don't think you need to make it better right now. I
don't know offhand how you invoke an external command more efficiently from
Java.
* [Is this going to enable it for all
tests?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-b1c721618608f703239339811634ef3dR51]
Is that a good idea can we only enable it for just the unit tests that require
it?
* [Should use execute instead of submit unless consuming the result
future|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR77]
* [Same here |
https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR120]
I'll look at the dtests now.
> Allow using custom script for chronicle queue BinLog archival
> -------------------------------------------------------------
>
> Key: CASSANDRA-14373
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14373
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stefan Podkowinski
> Assignee: Pramod K Sivaraju
> Priority: Major
> Labels: lhf, pull-request-available
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It would be nice to allow the user to configure an archival script that will
> be executed in {{BinLog.onReleased(cycle, file)}} for every deleted bin log,
> just as we do in {{CommitLogArchiver}}. The script should be able to copy the
> released file to an external location or do whatever the author hand in mind.
> Deleting the log file should be delegated to the script as well.
> See CASSANDRA-13983, CASSANDRA-12151 for use cases.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
