[
https://issues.apache.org/jira/browse/CASSANDRA-14823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649460#comment-16649460
]
Sam Tunnicliffe commented on CASSANDRA-14823:
---------------------------------------------
This is a nasty one. The patch essentially LGTM, though I've pushed a couple of
tiny commits with minor suggestions
[here|https://github.com/beobal/cassandra/commits/14823-3.0]. The first fixes a
couple of typos, tweaks the comments slightly in SSTRI and changes a param
name. The second switches from using Guava {{Preconditions}} to {{Verify}},
which is not a big deal at all, but seems marginally better aligned
semantically. e.g.
{quote}If checking whether the _caller_ has violated your method or
constructor's contract (such as by passing an invalid argument), use the
utilities of the Preconditions class instead."
{quote}
from [the Verify
doc|https://google.github.io/guava/releases/18.0/api/docs/com/google/common/base/Verify.html])
One last thing to note is that the merge to 3.11 is not entirely clean but it
is trivially resolvable and tests do pass once merged.
> Legacy sstables with range tombstones spanning multiple index blocks create
> invalid bound sequences on 3.0+
> -----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-14823
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14823
> Project: Cassandra
> Issue Type: Bug
> Reporter: Blake Eggleston
> Assignee: Blake Eggleston
> Priority: Major
> Fix For: 3.0.x, 3.11.x
>
>
> During upgrade from 2.1 to 3.0, reading old sstables in reverse order would
> generate invalid sequences of range tombstone bounds if their range
> tombstones spanned multiple column index blocks. The read fails in different
> ways depending on whether the 2.1 tables were produced by a flush or a
> compaction.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
