[
https://issues.apache.org/jira/browse/CASSANDRA-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701211#comment-16701211
]
Blake Eggleston commented on CASSANDRA-14588:
---------------------------------------------
In my initial review I missed that AbstractCollection has a useful toString
method, and it would be nice if it was duplicated it in AbstractRow to help
with debugging. That can just be added on commit though.
> Unfiltered.isEmpty conflicts with Row extends AbstractCollection.isEmpty
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-14588
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14588
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
> Reporter: Benedict
> Assignee: Benedict
> Priority: Minor
> Fix For: 4.0, 3.0.x, 3.11.x
>
>
> The isEmpty() method’s definition for a Row is incompatible with that for a
> Collection. The former can return false even if there is no ColumnData for
> the row (i.e. the collection is of size 0).
>
> This currently, by chance, doesn’t cause us any problems. But if we ever
> pass a Row as a Collection to a method that invokes isEmpty() and then
> expects (for correctness) that the _collection_ portion is not empty, it will
> fail.
>
> We should probably have an asCollection() method to obtain a collection from
> a Row, and not implement Collection directly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
