Sam Tunnicliffe created CASSANDRA-14920:
-------------------------------------------

             Summary: Some comparisons used for verifying paging queries in 
dtests only test the column names and not values
                 Key: CASSANDRA-14920
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14920
             Project: Cassandra
          Issue Type: Bug
          Components: Testing
            Reporter: Sam Tunnicliffe


The implementation of {{PageAssertionMixin::assertEqualIgnoreOrder}} introduced 
in CASSANDRA-14134 can't be used to compare expected and actual results when 
the row data is represented by a {{dict}}. The underlying 
{{list_to_hashed_dict}} function expected lists of values and when it 
encounters a dict, it constructs its normalized list using only the keys. So 
the actual result values may be completely wrong, but as long as the field 
names are the same the equality check will pass. This affects only 
{{paging_tests.py}} and {{upgrade_tests/paging_test.py}}, and looks like it 
maybe a leftover from an earlier dev iteration, as some tests in the affected 
fixtures are already using the alternative (and correct) 
{{assertions.py::assert_lists_equal_ignoring_order}}.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to