[ https://issues.apache.org/jira/browse/CASSANDRA-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718123#comment-16718123 ]
Dinesh Joshi commented on CASSANDRA-14928: ------------------------------------------ [~aweisberg] the changes look good. I wonder if it would be better to add a helper {{FBUtilities::getReleaseVersionMajor()}}. Also note that the {{FBUtilities::getReleaseVersionString()}} may return a string "Unknown" in which case you'll experience an exception. Ideally, we'd like to assert that the version is not "unknown". > MigrationManager attempts to pull schema from different major version nodes > --------------------------------------------------------------------------- > > Key: CASSANDRA-14928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14928 > Project: Cassandra > Issue Type: Bug > Components: 4.0, Distributed Metadata > Reporter: Ariel Weisberg > Assignee: Ariel Weisberg > Priority: Blocker > Fix For: 4.0, 2.2.x, 3.0.x, 3.11.x > > > MigrationManager will do the version check against nodes it hasn't connected > to yet so it doesn't know their messaging service version. We should also > check the version in gossip as an additional layer of protection. > This causes many of the upgrade tests to fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org