[
https://issues.apache.org/jira/browse/CASSANDRA-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022913#comment-13022913
]
Jonathan Ellis commented on CASSANDRA-2530:
-------------------------------------------
Thanks for the patch!
I'm slightly against having both Float and Double -- I'd like to discourage
premature optimization and using 4 bytes for floating point instead of 8 is
almost always the wrong space:accuracy tradeoff today.
Similarly not sure there is a raison d'être for ByteType.
This looks wrong:
{noformat}
+ if (bytes.remaining() != 4)
+ {
+ throw new MarshalException("A double is exactly 8 bytes) :
"+bytes.remaining());
+ }
{noformat}
Please check use of whitespace w/ http://wiki.apache.org/cassandra/CodeStyle.
Would like to see new Types covered by RoundTripTest.
Would like to see new Types integrated into CQL; this does involve digging into
the Antlr code though (to allow it to recognize new literal types). So if you
want we can open a separate ticket for that.
> Additional AbstractType data type definitions to enrich CQL
> -----------------------------------------------------------
>
> Key: CASSANDRA-2530
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2530
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8.0
> Reporter: Rick Shaw
> Priority: Trivial
> Labels: cql
> Attachments: patch-to-add -5 -new-AbstractTypes.txt
>
>
> Provide 5 additional Datatypes: ByteType, DateType, BooleanType, FloatType,
> DoubleType.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
