[ https://issues.apache.org/jira/browse/CASSANDRA-14421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725378#comment-16725378 ]
Ariel Weisberg edited comment on CASSANDRA-14421 at 12/19/18 10:05 PM: ----------------------------------------------------------------------- [~philipthompson] I ended up finding a bunch of upgrade tests that weren't running and while fixing those I found some additional CCM changes worth doing. https://github.com/riptano/ccm/pull/688 One issue was that when manually setting the version of a cluster it was setting the cluster version field to a string instead of a LooseVersion instance that is normally used and some tests tripped up on that. Another issue was that some tests downgrade from 4.0 to pre-4.0 and it's helpful if CCM automatically removes unsupported config options in that scenario. I already added automatic removal of config options from pre-4.0 to 4.0. I'm not sure why the checks are failing on distutils? was (Author: aweisberg): [~philipthompson] I ended up finding a bunch of upgrade tests that weren't running and while fixing those I found some additional CCM changes worth doing. https://github.com/riptano/ccm/pull/688 One issue was that when manually setting the version of a cluster it was setting the cluster version field to a string instead of a LooseVersion instance that is normally used and some tests tripped up on that. Another issue was that some tests downgrade from 4.0 to pre-4.0 and it's helpful if CCM automatically removes unsupported config options in that scenario. I already added automatic removal of config options from pre-4.0 to 4.0. > Reenable upgrade tests > ---------------------- > > Key: CASSANDRA-14421 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14421 > Project: Cassandra > Issue Type: Task > Components: Testing > Reporter: Sam Tunnicliffe > Assignee: Ariel Weisberg > Priority: Major > Fix For: 4.0 > > > Since dtests were switched to pytest & python3 in CASSANDRA-13134, the > upgrade tests have been non-functional and are deselected by default (though > even if you ran with the {{--execute-upgrade-tests}} they wouldn't work). > They're further broken by CASSANDRA-14420, as {{upgrade_manifest}} relies on > {{CASSANDRA_VERSION_FROM_BUILD}}. We need to get them, or something > equivalent, up and running. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org