[ 
https://issues.apache.org/jira/browse/CASSANDRA-14905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731424#comment-16731424
 ] 

Ariel Weisberg commented on CASSANDRA-14905:
--------------------------------------------

LGTM. There is some whitespace churn in the 3.11 patch that isn't in the other 
patches. I would rather do a dedicated whitespace ticket and tackle more files 
then sneak it in here since we aren't touching that code.

Who is getting the author credit here? Multiple author credits?

> if SizeEstimatesRecorder misses a 'onDropTable' notification, the 
> size_estimates table will never be cleared for that table.
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14905
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14905
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Metrics
>            Reporter: Aleksandr Sorokoumov
>            Assignee: Aleksandr Sorokoumov
>            Priority: Minor
>             Fix For: 3.0.x, 3.11.x, 4.0.x
>
>         Attachments: 14905-3.0-dtest.png, 14905-3.0-testall.png, 
> 14905-3.11-dtest.png, 14905-3.11-testall.png, 14905-4.0-dtest.png, 
> 14905-4.0-testall.png
>
>
> if a node is down when a keyspace/table is dropped, it will receive the 
> schema notification before the size estimates listener is registered, so the 
> entries for the dropped keyspace/table will never be cleaned from the table. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to