[
https://issues.apache.org/jira/browse/CASSANDRA-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749397#comment-16749397
]
Dinesh Joshi commented on CASSANDRA-14991:
------------------------------------------
Hi [~aweisberg]. Thanks for looking at the PR. I have addressed comments 1 & 2.
Regarding #3, the issue is that when we do optional client auth, we build the
truststore based on the value in the configuration so I left it to the value of
the client auth variable. When someone sets client auth to off, it is ok to
have invalid values for the truststore configuration. If we try to enforce
valid values it will deviate from its current behavior. Let me know if you have
any other comments.
> SSL Cert Hot Reloading should check for sanity of the new keystore/truststore
> before loading it
> -----------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-14991
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14991
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Encryption
> Reporter: Dinesh Joshi
> Assignee: Dinesh Joshi
> Priority: Major
> Labels: security
> Fix For: 4.0
>
>
> SSL Cert Hot Reloading assumes that the keystore & truststore are valid.
> However, a corrupt store or a password mismatch can cause Cassandra to fail
> accepting new connections as we throw away the old {{SslContext}}. This patch
> will ensure that we check the sanity of the certificates during startup and
> during hot reloading. This should protect against bad key/trust stores. As
> part of this PR, I have cleaned up the code a bit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]