[
https://issues.apache.org/jira/browse/CASSANDRA-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795346#comment-16795346
]
Aleksey Yeschenko commented on CASSANDRA-14822:
-----------------------------------------------
It's deprecated and emits a warning in 3.0/3.11, followed by removal in 4.0.
It's a common pattern w/ C* syntax and features, nothing new or interesting.
Arguably removal was handled insufficiently carefully in that CQLSH output had
not been modified. As [~jolynch] is pointing out, at the very least it's
something that needs to be addressed.
But if for whatever reason it's unfeasible to update the in-tree driver
(assuming upstream driver has this fixed already), or to get the upstream
driver updated (assuming it hasn't), then I see no problem with treating this
softer, with a warning (and a client warn) instead of an exception.
If avoidable, though, I'd prefer to keep that param properly dead, and fix the
issue on CQLSH side. Those two params were properly silly and deserved to
perish with no trace.
> Cassandra 4.0 doesn't output DESCRIBE TABLE representations that are valid
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-14822
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14822
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
> Reporter: Joseph Lynch
> Assignee: Joseph Lynch
> Priority: Low
> Labels: cqlsh
>
> Looks like right now on 4.0 the {{DESCRIBE}} output of a table is no longer
> valid since {{dclocal_read_repair_chance}} was removed:
> {noformat}
> cqlsh> CREATE KEYSPACE test WITH replication = {'class': 'SimpleStrategy',
> 'replication_factor': 1};
> cqlsh> CREATE TABLE test.test (key text, value text, PRIMARY KEY(key));
> cqlsh> DESCRIBE TABLE test.test
> CREATE TABLE test.test (
> key text PRIMARY KEY,
> value text
> ) WITH bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.0
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = '99p';
> {noformat}
> If you then try to copy and past that output it fails:
> {noformat}
> cqlsh> CREATE TABLE test.test2 (
> ... key text PRIMARY KEY,
> ... value text
> ... ) WITH bloom_filter_fp_chance = 0.01
> ... AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> ... AND comment = ''
> ... AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> ... AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> ... AND crc_check_chance = 1.0
> ... AND dclocal_read_repair_chance = 0.0
> ... AND default_time_to_live = 0
> ... AND gc_grace_seconds = 864000
> ... AND max_index_interval = 2048
> ... AND memtable_flush_period_in_ms = 0
> ... AND min_index_interval = 128
> ... AND read_repair_chance = 0.0
> ... AND speculative_retry = '99p';
> SyntaxException: Unknown property 'dclocal_read_repair_chance'
> {noformat}
> Currently we leave in {{dclocal_read_repair_chance}} and
> {{read_repair_chance}} for the drivers per the comments left during
> CASSANDRA-13910.
> I think we can just ignore those parameters in the validation/creation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
