[ 
https://issues.apache.org/jira/browse/CASSANDRA-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson updated CASSANDRA-15058:
----------------------------------------
    Test and Documentation Plan: A distributed in-jvm test was added to make 
sure we don't overcount
                         Status: Patch Available  (was: Open)

attaching patch to not close the iterator after digesting it;

https://github.com/krummas/cassandra/commits/marcuse/15058-3.0
https://github.com/krummas/cassandra/commits/marcuse/15058-3.11
https://github.com/krummas/cassandra/commits/marcuse/15058-trunk

https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15058-3.0
https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15058-3.11
https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15058-trunk

> Avoid double counting read latencies for digest queries
> -------------------------------------------------------
>
>                 Key: CASSANDRA-15058
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15058
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Observability/Metrics
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.x
>
>
> We are closing the {{UnfilteredPartitionIterator}} wrapped with 
> {{withMetricsRecording}} twice when we get digest requests - closing it calls 
> {{onClose}} and that makes the metrics update twice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to