[ https://issues.apache.org/jira/browse/CASSANDRA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836799#comment-16836799 ]
Dinesh Joshi commented on CASSANDRA-15108: ------------------------------------------ Hi [~bdeggleston], I think the PR is looking good. There is just one suggestion. Instead of using double checked locking, you can use {{computeIfAbsent}} API. I've made the relevant change here: https://github.com/beobal/cassandra/compare/15108...dineshjoshi:15108-trunk-review?expand=1 > Support building Cassandra with JDK 11 > -------------------------------------- > > Key: CASSANDRA-15108 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15108 > Project: Cassandra > Issue Type: Improvement > Components: Build > Reporter: Blake Eggleston > Assignee: Blake Eggleston > Priority: Normal > > With the changes in java 8 support and licensing, we should be able to build > and run Cassandra with java 11. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org