[
https://issues.apache.org/jira/browse/CASSANDRA-15120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844940#comment-16844940
]
Sam Tunnicliffe commented on CASSANDRA-15120:
---------------------------------------------
So everything looks reasonable to me, except for the changes to
{{MessagingService::listen}}. I presume these were not intended to be left in
the patch, and it seems to work fine with them reverted.
Nit: the comment on {{SEPW}} line 112 is no longer 100% correct as it isn't
explicitly concerned about the shutdown state of the {{SEPE}} any more.
Also, it isn't new but the logging in the catch block of {{SEPW::run}} may not
happen depending on the stability inspector.
> Nodes that join the ring while another node is MOVING build an invalid view
> of the token ring
> ---------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15120
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip, Cluster/Membership
> Reporter: Benedict
> Assignee: Benedict
> Priority: Normal
>
> Gossip only updates the token metadata for nodes in the NORMAL, SHUTDOWN or
> LEAVING* statuses. MOVING and REMOVING_TOKEN nodes do not have their ring
> information updated (nor do others, but these other states _should_ only be
> taken by nodes that are not members of the ring).
> If a node missed the most recent token-modifying events because they were not
> a member of the ring when they happened (or because Gossip was delayed to
> them), they will retain an invalid view of the ring until the node enters the
> one of the NORMAL, SHUTDOWN or LEAVING states.
> *LEAVING is populated differently, however, and in a probably unsafe manner
> that this work will also address.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
