[ 
https://issues.apache.org/jira/browse/CASSANDRA-15098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889202#comment-16889202
 ] 

Jay Zhuang edited comment on CASSANDRA-15098 at 7/19/19 10:07 PM:
------------------------------------------------------------------

Rebased the code and passed tests, please review:

| Branch | uTest | jvm-dTest | dTest | dTest vnode |
| [15098-3.0|https://github.com/instagram/cassandra/tree/15098-3.0] | [#107 
passed |https://circleci.com/gh/Instagram/cassandra/107] | [#108 
failed|https://circleci.com/gh/Instagram/cassandra/108], known issue: 
CASSANDRA-15239 | [#110 
failed|https://circleci.com/gh/Instagram/cassandra/110], passed locally, known 
issue: CASSANDRA-14595 | [#109 failed | 
https://circleci.com/gh/Instagram/cassandra/109], passed locally, known issue: 
CASSANDRA-14595 |
| [15098-3.11|https://github.com/instagram/cassandra/tree/15098-3.11] | [#100 
passed|https://circleci.com/gh/Instagram/cassandra/100] | [#99 
passed|https://circleci.com/gh/Instagram/cassandra/99] | [#111 
failed|https://circleci.com/gh/Instagram/cassandra/111], passed locally: 
CASSANDRA-14595 | [#112 
failed|https://circleci.com/gh/Instagram/cassandra/112], passed locally: 
CASSANDRA-14595 |
| [15098-trunk|https://github.com/instagram/cassandra/tree/15098-trunk] | [#104 
failed|https://circleci.com/gh/Instagram/cassandra/104], passed locally and 
re-run passed [#117|https://circleci.com/gh/Instagram/cassandra/117] | [#105 
passed|https://circleci.com/gh/Instagram/cassandra/105] | [#114 
passed|https://circleci.com/gh/Instagram/cassandra/114] | [#113 
passed|https://circleci.com/gh/Instagram/cassandra/113] |



was (Author: jay.zhuang):
Rebased the code and passed tests, please review:

 | Branch | uTest | jvm-dTest | dTest | dTest vnode |
| [15098-3.0|https://github.com/instagram/cassandra/tree/15098-3.0] | [#107 
passed |https://circleci.com/gh/Instagram/cassandra/107] | [#108 
failed|https://circleci.com/gh/Instagram/cassandra/108], known issue: 
CASSANDRA-15239 | [#110 
failed|https://circleci.com/gh/Instagram/cassandra/110], passed locally, known 
issue: CASSANDRA-14595 | [#109 failed | 
https://circleci.com/gh/Instagram/cassandra/109], passed locally, known issue: 
CASSANDRA-14595 |
| [15098-3.11|https://github.com/instagram/cassandra/tree/15098-3.11] | [#100 
passed|https://circleci.com/gh/Instagram/cassandra/100] | [#99 
passed|https://circleci.com/gh/Instagram/cassandra/99] | [#111 
failed|https://circleci.com/gh/Instagram/cassandra/111], passed locally: 
CASSANDRA-14595 | [#112 
failed|https://circleci.com/gh/Instagram/cassandra/112], passed locally: 
CASSANDRA-14595 |
| [15098-trunk|https://github.com/instagram/cassandra/tree/15098-trunk] | [#104 
failed|https://circleci.com/gh/Instagram/cassandra/104], passed locally and 
re-run passed [#117|https://circleci.com/gh/Instagram/cassandra/117] | [#105 
passed|https://circleci.com/gh/Instagram/cassandra/105] | [#114 
passed|https://circleci.com/gh/Instagram/cassandra/114] | [#113 
passed|https://circleci.com/gh/Instagram/cassandra/113] |


> Endpoints no longer owning tokens are not removed for vnode
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-15098
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15098
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Cluster/Gossip
>            Reporter: Jay Zhuang
>            Assignee: Jay Zhuang
>            Priority: Normal
>
> The logical here to remove endpoints no longer owning tokens is not working 
> for multiple tokens (vnode):
> https://github.com/apache/cassandra/blob/06209037ea56b5a2a49615a99f1542d6ea1b2947/src/java/org/apache/cassandra/service/StorageService.java#L2505
> And it's very expensive to copy the tokenmetadata for every check.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to