[ 
https://issues.apache.org/jira/browse/CASSANDRA-15225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901962#comment-16901962
 ] 

Liudmila Kornilova commented on CASSANDRA-15225:
------------------------------------------------

Thank you for reviewing the code, [~benedict]

It sounds like a better approach because some {{Throwables}} should not be 
re-thrown as checked (e.g. {{Error}} is a "serious problems that a reasonable 
application should not try to catch"). Also no additional wrappers

I pushed third commit

> FileUtils.close() does not handle non-IOException
> -------------------------------------------------
>
>                 Key: CASSANDRA-15225
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15225
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/SSTable
>            Reporter: Benedict
>            Assignee: Liudmila Kornilova
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 3.0.x, 3.11.x, 4.0.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This can lead to {{close}} not being invoked on remaining items



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to