Jon Meredith commented on CASSANDRA-15272:

+1 from me.

It's probably worth waiting until CASSANDRA-15170 lands first and it'll only 
need a minor tweak to change GOSSIP/NETWORK import path.

Only one nit, instead of commenting out the compressed test, what do you think 
about using @Ignore instead

{{@Ignore("test requires CASSANDRA-13938 to be merged")}}

That gives somebody looking at the output from test runners a better chance of 
noticing it is disabled for a reason and enabling in future.

> Enhance & reenable RepairTest
> -----------------------------
>                 Key: CASSANDRA-15272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Consistency/Repair
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Normal
> Currently the In-JVM RepairTest is not enabled on trunk (See for more info: 
> CASSANDRA-13938). This patch enables the In JVM RepairTest. It adds a new 
> test that tests the compression=off path for SSTables. It will help catch any 
> regressions in repair on this path. This does not fix the issue with the 
> compressed sstable streaming (CASSANDRA-13938). That should be addressed in 
> the original ticket.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to