Venkata Harikrishna Nukala commented on CASSANDRA-15227:

[~benedict] Made the changes and updated the branch (squashed commits). 

Made changes to pass _ExecutorServiceInitialiser_ as the last param to make 
enum easy to read. I tried passing executor as the param for the constructor 
but felt passing jmxName, jmxType, etc... as params look consistent and clean. 
Removed jmxName as member variable form Stage. Using thread instance comparison 
for _Gossiper_ as it needs to check if the code is being executed by executor 
thread or not. Created a separate class (_JMXEnabledSingleThreadExecutor_) 
instead _JMXEnabledThreadPoolExecutor_ as somebody can change the core/max 
threads using JMX which _JMXEnabledSingleThreadExecutor_ doesn't allow. Now 
Gossip stage literally uses only one thread. _ANTI_ENTROPY, MIGRATION & MISC_ 
stages use a single thread and can use _JMXEnabledSingleThreadExecutor_ but did 
not make changes because I thought it is worth tracking that as a separate 
change and maybe there could be some debate around them.

> Remove StageManager
> -------------------
>                 Key: CASSANDRA-15227
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15227
>             Project: Cassandra
>          Issue Type: Task
>          Components: Local/Other
>            Reporter: Benedict
>            Assignee: Venkata Harikrishna Nukala
>            Priority: Normal
>             Fix For: 4.0
> his is a minor cleanup; this class should not exist, but should be embedded 
> in the Stage enum.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to