[
https://issues.apache.org/jira/browse/CASSANDRA-15228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920747#comment-16920747
]
Benedict commented on CASSANDRA-15228:
--------------------------------------
It had been a long time since I looked at the commit log code, and taking a
look now, this has obviously become tightly interwoven with other extended
behaviours (encryption and compression) that I would prefer not to unpick
anytime soon. This isn't the simplifying change I had hoped it would be. I
think it would be preferable to defer any refactoring until we can address
CASSANDRA-9834.
We can instead, at any time during 4.0 (or later if we choose) modify the
replayer to simply ignore the lack of a final sync marker, and to attempt to
replay the contents in-between, to restore earlier persistence behaviour
without any user-visible file format changes.
> Commit Log should not use sync markers
> --------------------------------------
>
> Key: CASSANDRA-15228
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15228
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Commit Log
> Reporter: Benedict
> Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> The sync markers existed to permit file re-use. Since we no longer re-use
> files, they no longer provide any value. However, they _can_ corrupt the
> commit log for replay in the event of a process crash. Before we release
> 4.0, we should ideally remove the sync markers entirely.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
