[
https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936427#comment-16936427
]
mck edited comment on CASSANDRA-14655 at 9/24/19 2:35 PM:
----------------------------------------------------------
[~sumanth.pasupuleti],
- unit tests look good,
- i think the {{"cassandra-driver-core"}} lines in the build.xml can now be
updated and uncommented, see {{"UPDATE AND UNCOMMENT"}} sections,
- for LoaderOptions and CqlConfigHelper are there docs we want to update? (ie
to use `host:port`?
- is the {{nativePort}} parameter needed anymore in
{{NativeSSTableLoaderClient}}'s constructor? the caller can put that into the
{{hosts}} parameter, (and then in the {{init(..)}} method (line 73) the cluster
builder called instead with {{addContactPointsWithPorts(hosts)}},
- i am still looking into the dtests…
bq. … the caller can put that into the {{hosts}} parameter, …
For example it looks like {{CqlBulkRecordWriter}} (in the call to
{{resolveHostAddresses}}), while {{BulkLoader}}+{{LoaderOptions}} could be
doing similar if {{LoaderOptions.Builder.build()}} looped through its {{hosts}}
and put in {{nativePort}} when undefined.
was (Author: michaelsembwever):
[~sumanth.pasupuleti],
- unit tests look good,
- i think the {{"cassandra-driver-core"}} lines in the build.xml can now be
updated and uncommented, see {{"UPDATE AND UNCOMMENT"}} sections,
- for LoaderOptions and CqlConfigHelper are there docs we want to update? (ie
to use `host:port`?
- is the {{nativePort}} parameter needed anymore in
{{NativeSSTableLoaderClient}}'s constructor? the caller can put that into the
{{hosts}} parameter, (and then in the {{init(..)}} method (line 73) the cluster
builder called instead with {{addContactPointsWithPorts(hosts)}},
- i am still looking into the dtests…
bq. … the caller can put that into the {{hosts}} parameter, …
For example it looks like {{CqlBulkRecordWriter}} (in the call to
{{resolveHostAddresses}}), while {{BulkLoader}}+{{LoaderOptions}} could be
doing similar if {{LoaderOptions.Builder.build()}} looped through its {{hosts}}
and put in {{nativePort}} when undefined.
> Upgrade C* to use latest guava (27.0)
> -------------------------------------
>
> Key: CASSANDRA-14655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14655
> Project: Cassandra
> Issue Type: Improvement
> Components: Dependencies
> Reporter: Sumanth Pasupuleti
> Assignee: Sumanth Pasupuleti
> Priority: Low
> Labels: 4.0-feature-freeze-review-requested
> Fix For: 4.x
>
>
> C* currently uses guava 23.3. This JIRA is about changing C* to use latest
> guava (26.0). Originated from a discussion in the mailing list.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
