[
https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938410#comment-16938410
]
Sumanth Pasupuleti commented on CASSANDRA-14655:
------------------------------------------------
[~michaelsembwever] Incorporated your feedback and here is the consolidated
commit :
[https://github.com/sumanth-pasupuleti/cassandra/commit/0798bfe9b54b0c1cd49b41beffb9f09c1c5c8305].
Diff from trunk:
[https://github.com/apache/cassandra/compare/trunk...sumanth-pasupuleti:guava_27_trunk?expand=1]
{quote}i think the "cassandra-driver-core" lines in the build.xml can now be
updated and uncommented, see "UPDATE AND UNCOMMENT" sections,
{quote}
Fixed
{quote}for LoaderOptions and CqlConfigHelper are there docs we want to update?
(ie to use `host:port`?
{quote}
Could not find existing documentation around these tools.
{quote}is the nativePort parameter needed anymore in
NativeSSTableLoaderClient's constructor? the caller can put that into the hosts
parameter, (and then in the init(..) method (line 73) the cluster builder
called instead with addContactPointsWithPorts(hosts)
{quote}
Made changes to remove nativePort parameter from NativeSSTableLoaderClient's
constructor. LoaderOptions.Builder.build() already puts nativePort into the
hosts (line 152), so I didn't have to make any changes there - please let me
know in case I missed out anything here.
Status of Tests
([https://circleci.com/workflow-run/6ff402e1-a68b-4092-bc6a-62b10cc36d2d])
* Passing UTs and jvm dtests
* DTests without vnodes - 1 failure (cql_test.TestCQLSlowQuery)
* DTests with vnodes - 1 failure
(repair_tests.incremental_repair_test.TestIncRepair)
> Upgrade C* to use latest guava (27.0)
> -------------------------------------
>
> Key: CASSANDRA-14655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14655
> Project: Cassandra
> Issue Type: Improvement
> Components: Dependencies
> Reporter: Sumanth Pasupuleti
> Assignee: Sumanth Pasupuleti
> Priority: Low
> Labels: 4.0-feature-freeze-review-requested
> Fix For: 4.x
>
>
> C* currently uses guava 23.3. This JIRA is about changing C* to use latest
> guava (26.0). Originated from a discussion in the mailing list.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
