Sam Tunnicliffe updated CASSANDRA-15193:
          Fix Version/s:     (was: 3.11.x)
                             (was: 3.0.x)
          Since Version: 3.0.0
    Source Control Link: 
             Resolution: Fixed
                 Status: Resolved  (was: Ready to Commit)

Rebased and incorporated (most of) the review comments. There are no new test 
failures, so committed to 3.0 in {{0388d89e29393d0b1f50baa24848bc8cb0a7c9a3}} 
and merged to 3.11 and trunk. This isn't an issue in trunk so that only 
includes the new yaml setting, marked as deprecated and having no effect, to 
make upgrades from 2.1->3.x->4.0 less painful.

dtests ran using the branch in this PR: 

> Add ability to cap max negotiable protocol version
> --------------------------------------------------
>                 Key: CASSANDRA-15193
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15193
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Messaging/Client
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Normal
>             Fix For: 3.0.19, 3.11.5, 4.0-alpha
> 3.0 and native protocol V4 introduced a change to how PagingState is 
> serialized. Unfortunately that can break requests during upgrades: since 
> paging states are opaque, it's possible for a client to receive a paging 
> state encoded as V3 on a 2.1 node, and then send it to a 3.0 node on a V4 
> session. The version of the current session will be used to deserialize the 
> paging state, instead of the actual version used to serialize it, and the 
> request will fail.
> CASSANDRA-15176 solves half of this problem by enabling 3.0 nodes to 
> serialize mis-versioned PagingStates. To address the other side of the issue, 
> 2.1 nodes receiving V4 PagingStates, we can introduce a property to cap the 
> max native protocol version that the 3.0 nodes will negotiate with clients. 
> If we cap this to V3 during upgrades, no V4 connections will be established 
> and so no incompatible PagingStates will be sent to clients.

This message was sent by Atlassian Jira

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to