Michael Semb Wever commented on CASSANDRA-14477:

 - could you split the test method into three methods, one for each of the 
configuration scenarios being tested?
 - in the 3.11 branch could you return {{num_tokens}} to a boxed type, 
CASSANDRA-12199 only intended primitives to be used where there was a default 
value, and here you've demonstrated that there shouldn't be a default value as 
{{num_tokens}} and {{initial_token}} are exclusive,
 - and, could you rebase both branches please? (test currently fails for me 
without rebasing)

> The check of num_tokens against the length of inital_token in the yaml 
> triggers unexpectedly
> --------------------------------------------------------------------------------------------
>                 Key: CASSANDRA-14477
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14477
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Config
>            Reporter: Vincent White
>            Assignee: Vincent White
>            Priority: Low
> In CASSANDRA-10120 we added a check that compares num_tokens against the 
> number of tokens supplied in the yaml via initial_token. From my reading of 
> CASSANDRA-10120 it was to prevent cassandra starting if the yaml contained 
> contradictory values for num_tokens and initial_tokens which should help 
> prevent misconfiguration via human error. The current behaviour appears to 
> differ slightly in that it performs this comparison regardless of whether 
> num_tokens is included in the yaml or not. Below are proposed patches to only 
> perform the check if both options are present in the yaml.
> ||Branch||
> |[3.0.x|https://github.com/apache/cassandra/compare/cassandra-3.0...vincewhite:num_tokens_30]|
> |[3.x|https://github.com/apache/cassandra/compare/cassandra-3.11...vincewhite:num_tokens_test_1_311]|

This message was sent by Atlassian Jira

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to