[
https://issues.apache.org/jira/browse/CASSANDRA-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963885#comment-16963885
]
Benedict Elliott Smith commented on CASSANDRA-15265:
----------------------------------------------------
LGTM.
One tiny stylistic suggestion: I think it can be clearer to a reader when
predicates are phrased so that they read like a predicate. In this case we
can't easily use our normal {{is}} prefix, but I guess we could use
{{areGlobalCompactionsPaused}} or alternatively
{{isGlobalCompactionStopRequested}} for consistency with the {{isStopRequested}}
Absolutely not blocking; happy for you to name and commit however you like.
> Index summary redistribution can start even when compactions are paused
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-15265
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15265
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> When we pause autocompaction for upgradesstables/scrub/cleanup etc we pause
> all compaction strategies to make sure we can grab all sstables, index
> summary redistribution does not pause and this can cause us to fail the
> operation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
