[ 
https://issues.apache.org/jira/browse/CASSANDRA-13974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sam Tunnicliffe updated CASSANDRA-13974:
----------------------------------------
    Status: Ready to Commit  (was: Review In Progress)

LGTM. There's 1 nit which you could ignore or fix on commit : in the 
{{Directories}} constructor, the check for old format directories was inlined 
in the 3.11 branch but in the 4.0 version the {{olderDirectoryExists}} is still 
there.

There's also a couple of failing dtests against trunk, but I'm having trouble 
even running those 2 tests locally, if they look ok to you I'm +1. 


> Bad prefix matching when figuring out data directory for an sstable
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-13974
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13974
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Core
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.x
>
>
> We do a "startsWith" check when getting data directory for an sstable, we 
> should match including File.separator



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to