[
https://issues.apache.org/jira/browse/CASSANDRA-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028135#comment-13028135
]
Sylvain Lebresne commented on CASSANDRA-2468:
---------------------------------------------
Comment:
* I'm uncomfortable with having closeAndDeleteQuietly() delete the non tmp
files (those really do not belong to the writer). Sure the calls are always
conditioned so that we shouldn't messed up, but I'm not sure it's worth the
risk of foot-shooting (it makes the function harder to use). I'd rather remove
that part, rename closeAndDeleteQuietly() to something like
cleanupIfNecessary() and call it every time in the finally block (which would
remove the need to check if the reader was successfully created every damn
time).
* Nitpick: I'd prefer moving the code for SSTableWriter.Builder inside
build() itself.
> Clean up after failed compaction
> --------------------------------
>
> Key: CASSANDRA-2468
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2468
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Aaron Morton
> Priority: Minor
> Fix For: 0.7.6, 0.8.1
>
> Attachments:
> 0001-clean-up-temp-files-after-failed-compaction-v08.patch,
> 0001-cleanup-temp-files-after-compaction-v07.patch
>
>
> (Started in CASSANDRA-2088.)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
