[
https://issues.apache.org/jira/browse/CASSANDRA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978700#comment-16978700
]
Jon Haddad commented on CASSANDRA-15402:
----------------------------------------
I don't have time to do a full review of this, but I did scan through it. I
don't see a single test, and there's close to zero comments. I'm afraid anyone
looking to review this thoroughly is going to have the same initial thoughts.
Given this patch affects a critical feature (backups), to me it's mandatory
that any new code be thoroughly documented and functionality proven correct via
tests.
Secondly, we're already in alpha, and new features were cut off a while ago.
Abstractly, I think this is an interesting feature, but I don't like it enough
to break with the community decision to push it into 4.0 (someone else might,
but I don't).
Lastly, I don't like the implementation details of this being a run time only
setting without any sort of persistence across restarts. The right way to do
this is to make the setting per-table, and part of the schema. Once we get
into system schema modifications we start to drift further into more complexity
(since now we also have to handle the upgrade path) and I again point to the
trunk feature freeze to hold off on the work here.
Longer term (5.0 for example) I think I could find time to review and help you
get it merged in, but as of now any time I spend working on Cassandra will be
put towards helping get 4.0 out the door, not pushing the date back further by
adding last minute features.
> Make incremental backup configurable per keyspace and table
> -----------------------------------------------------------
>
> Key: CASSANDRA-15402
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15402
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other, Tool/nodetool
> Reporter: maxwellguo
> Assignee: maxwellguo
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We know that when we do backup for cassandra, we can do full bakcup with
> snapshot, when we need to backup incremental data , incremental_backup can do
> some help .
> For snapshot we can just make snapshot for some keyspace/table. but
> incremental backup will do all data backup(make hard link for all sstable
> that flush from memtable or streaming ). we also know that commitlog's replay
> can do some keyspace /table 's filter.
> So I think for incremental backup we also need some filter for it.After all
> not all keyspace/table is so important to do backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
